Template talk:WikiProjectBannerShell

From Wikipedia, the free encyclopedia

Wikiproject Council This page relates to the WikiProject Council, a collaborative effort regarding WikiProjects in general. If you would like to participate, please visit the project discussion page.


Contents

[edit] Update samples?

I feel like we've discussed this before, but I can't recall the outcome: is it appropriate for us to add the {{WikiProjectBannerShell}} code to the project banner samples at Wikipedia:WikiProject Council/Guide/WikiProject? There don't seem to be a lot of non-compliant banners created these days, but these samples are used by those that are created (I've been asking). I don't necessarily want to make that page more complicated and yet, since we're updating all banners without asking their creators anyway... — TAnthonyTalk 17:22, 29 February 2008 (UTC)

Just following up on my question above ... — TAnthonyTalk 01:35, 8 April 2008 (UTC)
I would say, definitely yes. The WPBS nested code has become a de-facto standard across all WikiProject Banners - I don't think anyone has ever disputed its addition to a banner. So yes, add the code to the examples. I've been meaning to make a more public link to {{WPBannerMeta}} there as well... Happymelon 09:55, 8 April 2008 (UTC)

[edit] Policy proposal

There is a proposal at Wikipedia_talk:Talk_page_guidelines#Article_talk_page_banners for the guideline to include some aspects of banner placing and sequencing. All comments welcome. Johnbod (talk) 15:09, 11 March 2008 (UTC)

[edit] Non-supported template

Found a new project template not supported: {{WPSS}} at Talk:Apollo 12 (implementation). -MBK004 22:32, 18 March 2008 (UTC)

Y Done -- SatyrTN (talk / contribs) 23:01, 18 March 2008 (UTC)

[edit] Collapsed

Hm. Doesn't that parameter make this and {{WPB}} just about the same? Maybe we should merge them together now? -- SatyrTN (talk / contribs) 22:42, 26 March 2008 (UTC)

No, we should not merge them, and the collapsible should be removed. There has been much debate about this, we have two for the two different purposes, and this one was designed as the longer one. SandyGeorgia (Talk) 22:45, 26 March 2008 (UTC)
I would revert, but it's protected and I'm not an admin. SandyGeorgia (Talk) 22:46, 26 March 2008 (UTC)
I left a note for Happy-Melon, who may not be aware there are two different banners, the other is shorter, and this has been a contentious issue. (See also WP:FCDW/March 24, 2008). SandyGeorgia (Talk) 22:51, 26 March 2008 (UTC)
I think this probably fairly adequately explains why I made that change. Nonetheless, I have reverted as requested. I am fully aware of the two separate templates, and I have never had any satisfactory explanation as to why we need separate ones when one, with suitable options, will quite adequately suffice. It's probably best to respond to this rhetorical question at the TfD, if anywhere. Happymelon 22:56, 26 March 2008 (UTC)
Lovely. Clutter seems to be everywhere these days. SandyGeorgia (Talk) 23:03, 26 March 2008 (UTC)
From a technical standpoint, there's not much difference between {{WikiProjectBanners}} and {{WikiProjectBannerShell}} with a fully-collapsed option; given the way the parameters on the former work, it wouldn't even be necessary to change the calls themselves, since the functionality could be done through a meta-transclusion. Kirill 23:25, 26 March 2008 (UTC)

(outdent) Also from a technical standpoint, there's no reason *not* to keep the "collapsible" option on this template. I'd like to suggest bringing it back. -- SatyrTN (talk / contribs) 01:13, 27 March 2008 (UTC)

Agree, no reason not to have the added function, as it is entirely optional, and it doesn't change anything in the already transcluded instances. Please add back optional "collapsed" parameter. --Qyd (talk) 19:32, 28 March 2008 (UTC)
Seeing no objection? -- SatyrTN (talk / contribs) 06:36, 1 April 2008 (UTC)

[edit] WikiProjectBannerShell|1=|blp=yes breaks the template's display

Lately, adding the |blp=yes directly after |1= makes the projects not be displayed any longer (happened on Talk:Donald Patriquin). {{WikiProjectBannerShell|blp=yes|1= works, also adding |blp=yes after all the project banners works. This used to be different and should be fixed IMHO. BNutzer (talk) 16:01, 28 March 2008 (UTC)

That's entirely natural, and completely unavoidable. Think about what's going on. All the project banners are being assigned to the first parameter. The |1= is to ensure A) that the equals signs in the template calls don't screw up the template, and B) that whitespace is stripped from around the templates. If you put |blp=yes straight after |1=, then you're assigning nothing to the first parameter, and all the project banners (as well as "yes") to the blp parameter. I think you must be mistaken about this working before because there's no way I can think of that this functionality could ever have been provided without the displays of phantom "yes" quotes in wierd places. Happymelon 16:08, 28 March 2008 (UTC)
Was that ever different? I think it's always been that way, for code reasons. -- SatyrTN (talk / contribs) 18:09, 28 March 2008 (UTC)
You appear to be much more knowledgeable about how the code works than me. I was sure I had used it differently before, but I guess I am mistaken there. My apologies for the false alarm then. BNutzer (talk) 19:16, 28 March 2008 (UTC)
I was also unaware of the significance of order in this respect. I think a lot of people have no understanding of what the |1= actually does, so if it isn't emphasized anywhere that this must be the parameter sequence, perhaps it should. __meco (talk) 12:20, 2 April 2008 (UTC)

[edit] Banner problems

There seems to be an issue with {{WikiProject Israel}} causing bad display of project banners. See this revision of Talk:Pallywood. Kelly hi! 14:48, 29 March 2008 (UTC)

Y Done -- SatyrTN (talk / contribs) 15:33, 29 March 2008 (UTC)

[edit] Anomaly concerning Template:WikiProject Germany

As I just implemented the shell on Talk:Rudolf von Sebottendorf I experienced that the WP Germany template would not format correctly when placed last in order. When I moved it up in sequence, it now works fine. Perhaps someone can try and replicate this to see if there is a bug in that particular template's code. __meco (talk) 12:17, 2 April 2008 (UTC)

Wow, that's a tough one! I've spent ten minutes on it, but I have no idea what's wrong. Fortunately there seems to be an easy fix - just move the banner up one! Happymelon 15:51, 3 April 2008 (UTC)
Fixed, I hope. Hemmingsen 16:32, 3 April 2008 (UTC)

[edit] Anomaly concerning Template:WikiProject Mexico

At the head of a list, Mexico formats oddly:

This article is within the scope of the following WikiProjects:

Moving it down fixes this:

This article is within the scope of the following WikiProjects:

But what's the problem? —WWoods (talk) 16:19, 5 April 2008 (UTC)

Problems like this are almost always caused by extra linebreaks in the template code, which result in paragraph breaks when combined with other templates in certain orders. Playing around with the code to remove newlines usually fixes the problem, as I did here. Happymelon 16:32, 5 April 2008 (UTC)

[edit] Non-nested compliant banner

Resolved.

{{WikiProject Investment}} needs to be nested=yes compliant. Found anomaly on Talk:Wells Fargo. -MBK004 19:23, 9 April 2008 (UTC)

Converted to WPBannerMeta, thereby solving the many problems with the banner (including non-categorisation into Category:WikiProject banners, lack of |small= and |nested= functionality, poor formatting and substantial additional whitespace :D). Happymelon 20:20, 9 April 2008 (UTC)
It looks like your changes were reverted by a project member. May want to check back, but it is nesting properly. -MBK004 20:23, 9 April 2008 (UTC)
(edit conflict x2) With respect to Happy-melon, I replaced the template with custom code...they simply aren't at that point of needed complexity yet (they don't have a WP image or subcategories yet). As they grow, the code can adapt or they can move to the template. I will be leaving a note on their project talk page advising of the change, and will provide any requested code support in the future. Huntster (t@c) 20:24, 9 April 2008 (UTC)
Of course no one is going to force them to use WPBannerMeta, although I'd note that the current appearance could be exactly duplicated in rather fewer lines of code using the banner. As you say, as and when they need more functionality (particularly the class/importance assessments) I'd encourage them to use the meta-template. Regardless, the nested, small and whitespace issues have been fixed, and that's the most important thing. Happymelon 20:57, 9 April 2008 (UTC)

[edit] Some projects put a review in a comments subdirectory

I have discovered that some projects are putting their assessment notes in a subdirectory called Comments. I have no idea where this originated or where to ask questions about that. Anyway, I am here because I have a suggested improvement to this template.

The problem is that if the project banner is closed within the shell, the reader will not see the comments. I suggest that this template displays the comments if there are any. See Talk:Hastings for an example where I have simulated the result. MortimerCat (talk) 01:19, 14 April 2008 (UTC)

I think that this will create substantial and unnecessary levels of clutter on the talk page - the banner shell was originally created to reduce the amount of space taken up by talk-page messages, not increase it by transcluding extra content. Most of the project banners, particularly the one the comments were written for, will have functionality to display the comments within the (collapsible) banner, creating redundancy. Additionally, if there are headings within the comments section, the talk page ToC will move inside the banner shell, requiring a manual fix to correct. Without knowing how many of the 43,000 pages using WPBS would have this problem, I don't think it's a good idea to incorporate this functionality. Happymelon 08:23, 14 April 2008 (UTC)
I like the idea, and it would be easy to implement, but how about another approach. Rather than having the comments directly displayed in the banner shell, simply link to the Comments page. Consider how the {{documentation}} template decides whether or not to show that a template has a sandbox...a sort of "If /Comments page exists, display link." Would not unnecessary clutter those pages that don't have comments, but makes it easy for editors to see that they exist if they do. Very minimal real estate for what some consider valuable material. Should be simple to code. Huntster (t@c) 10:25, 14 April 2008 (UTC)
I agree, displaying the comments is negating why the shell is there in the first place. As Huntster suggests, I am replacing the ones I have added, and replacing with a note Expand banners to see assessment comments to indicate that comments are available. It would be nice to have t automated though. MortimerCat (talk) 19:57, 14 April 2008 (UTC)
Okay, for the perusal of interested parties, I've coded this functionality at User:Huntster/Sandbox (diff); and you can see how it would look here. Everything seems to test out fine. Minimal real estate when in use, and nothing looks different when not in use. Thoughts? Huntster (t@c) 11:54, 15 April 2008 (UTC)
Bump for additional comments. Huntster (t@c) 19:04, 2 May 2008 (UTC)
I like it MortimerCat (talk) 23:25, 15 April 2008 (UTC)

{{editprotected}} Okay, since there's been no additional comments on it, may I get an admin to replace the code with this diff? As previously stated, it takes up very little real estate while still conveying the requested information, and does not show if there are no comments. Huntster (t@c) 23:33, 7 May 2008 (UTC)

Y Done --cjllw ʘ TALK 23:58, 7 May 2008 (UTC)

[edit] Minor formatting discussion

There's a discussion about a minor (but very noticeable) formatting change going on here, which doesn't seem to be attracting very much interest; any comments from this page would be welcome, as the two are fairly similar. I dislike the change for reasons explained there; in fact I would like to propose that we add the "click show for further details" to WPBS, when the |collapsed=yes parameter is set (obviously telling viewers to click show when the banner is expanded is rather silly). It would make the banners more similar without disrupting the vast majority of instances (where WPBS is expanded). Thoughts? Happymelon 08:31, 14 April 2008 (UTC)

I'm all for it, as long as the "click show..." isn't put on a new line. As with the other template, the new line for those 5 words is not necessary, and just makes the box waste vertical space on the page. Equazcion /C 08:42, 14 Apr 2008 (UTC)

[edit] WikiProjectBannerShell and BLP notice (for Template:WPBiography request, see this)

The living=yes parameter in Template:WPBiography posts a BLP notice on the talk page. There probably is more than 100,000 articles tagged with {{WPBiography|living=yes}}. When Template:WPBiography is in WikiProjectBannerShell, the BLP notice is hidden. To overcoome this, some people additionally use {{WikiProjectBannerShell|blp=yes}} Also, some people add {{BLP}} to WikiProjectBannerShell to overcome the hidden BLP problem. See Talk:Eduardo Maruri as an example. While |blp=yes or {{BLP}} may be a solution, they seem redundant to the long used {{WPBiography|living=yes}}. Is it possible to change Template:WPBiography and/or WikiProjectBannerShell so that the BLP notice is not hidden when Template:WPBiography is in WikiProjectBannerShell? Doing so would eliminate a need to use {{WikiProjectBannerShell|blp=yes}} on the 100,000+ articles now using {{WPBiography|living=yes}}. Idealy, the living=yes parameter in Template:WPBiography should cause the BLP notice to appear outside and above WikiProjectBannerShell, if possible. Thanks. -- GregManninLB (talk) 15:31, 6 May 2008 (UTC)

The last option (adding |living=yes to {{WPBiography}} resulting in the BLP notice displaying outside the banner) is impossible without using a lot of messy javascript. It would be possible to cause the BLP notice to display even when the template was collapsed inside WPBS, but that would still look messy, particularly as the BLP notice is not a WikiProject banner and so should not be shelled with WPBS. The BLP notice does not actually belong inside the banner shell at all. I think that the only effective way of doing this would be to encourage the use of |blp=yes in WPBS as well as |living=yes in WPBiography. Once this system is widespread (by which I mean universal :D we could alter {{WPBiography}} to not display the BLP notice when |nested=yes is also defined (since it would be duplicated by the notice over WPBS) but still add to the relevant categories. Happymelon 18:14, 6 May 2008 (UTC)
Thanks for the reply, Happy. I copied and posted your reply at Template talk:WPBiography[1] so that everyone is on the same page. GregManninLB (talk) 16:52, 7 May 2008 (UTC)

[edit] Another template not supported

Just found {{WPFISHING}} that needs to have the nested parameter adding, found when looking at Talk:Whitby. There is also a problem of space caused by {{WikiProject Yorkshire}} when followed by this template unless they are both on the same line. Keith D (talk) 21:44, 8 May 2008 (UTC)

I'm actually in the process of upgrading WPFISHING now. I'll take a look at the other one when I have time. Huntster (t@c) 22:06, 8 May 2008 (UTC)
Thanks. Keith D (talk) 22:27, 8 May 2008 (UTC)
Y Done Huntster (t@c) 04:18, 9 May 2008 (UTC)

[edit] Fixed in IE

I just made some changes to how this template displays nested banners to fix some problems in IE. If you see problems in any browser, do a cache clear refresh first and see if that fixes it. Hopefully people using IE will now be able to see nested banners without them going partially out of the parent shell. If you see any templates or talk pages that are messed up because of this please let me know immediately and I will be happy to look into it. --CapitalR (talk) 22:32, 8 May 2008 (UTC)

You've done it again! Excellent work: the way the banners fall off the right-hand-side of the shell in IE7 was something I thoughth I'd just have to live with... my faith in humanity's ability to solve all the world's problems is restored :D. Happymelon 08:25, 9 May 2008 (UTC)
Yup, this was a tricky one. I'm a Firefox user myself, but had always felt sorry for those IE users having this template look funny, so I finally got around to fixing it for them. I'm rather surprised that it worked so smoothly and didn't have any unintended effects. Let's hope it stays that way.... --CapitalR (talk) 12:40, 9 May 2008 (UTC)
For me, I'm seeing an empty space in the last line of the shell. It looks as if it is missing a project or something, just a large blank area. Any way this can be fixed to compress only the projects with no black space like it was before? – Nurmsook! (talk) 17:56, 11 May 2008 (UTC)
Two questions: what browser are you using, and can you give me an example of a page where this occurs? It seems to look fine in the browsers I have tested it on for most pages. Also, please bypass your cache to see if that fixes it (Firefox=Ctrl+Shift+R, IE=Ctrl+F5). If it persists, could you also get me a screen shot? --CapitalR (talk) 18:00, 11 May 2008 (UTC)
I'm using Internet Explorer and it's occuring on all pages that use this shell (ex: Talk:Eric Brewer (ice hockey) screenshot), including the template page itself screenshot. I tried bypassing my cache twice and it has no effect, so I'm thinking it must be something in the script that got altered from the past two edits made to the template, as this was not occuring prior to these edits. – Nurmsook! (talk) 20:16, 11 May 2008 (UTC)
Great, thanks for the screenshot. I can't exactly tell what was wrong, but I think I fixed it, so let me know if everything is looking right for you now. It might take an hour or so for the job queue to get flushed and all of the changes to propagate to the talk pages, but I think it should be working properly now. Let's hope there were no side effects. Sorry for the trouble! --CapitalR (talk) 21:02, 11 May 2008 (UTC)
Looks all fixed to me. Thanks! – Nurmsook! (talk) 21:08, 11 May 2008 (UTC)

[edit] Non-compatible template

{{WikiProject West Virginia}} appears to add an empty line into the collapsed view, see Talk:Byzantine (band). BNutzer (talk) 21:30, 18 May 2008 (UTC)

Looks like someone fixed it; let me know if there are other problems. --CapitalR (talk) 23:12, 18 May 2008 (UTC)

[edit] Template:Record Labels

{{Record Labels}} needs the nesting code. Thanks in advance, -- Gyrofrog (talk) 22:12, 29 May 2008 (UTC)

Y Done. Huntster (t@c) 22:47, 29 May 2008 (UTC)
Thank you! -- Gyrofrog (talk) 14:26, 30 May 2008 (UTC)

[edit] Tmbox

The {{tmbox}} is the new ambox/mbox compatible meta-template for talk page message boxes. We are thinking of making the {{tmbox}} work with the {{WikiProjectBannerShell}}. Comments and advice from you who made / take care of / are interested in the {{WikiProjectBannerShell}} would be appreciated. See discussion at Template talk:Tmbox#Sizes / modes / shapes.

--David Göthberg (talk) 13:57, 31 May 2008 (UTC)