Template talk:Country flag2

From Wikipedia, the free encyclopedia

Template:Country flag2 is permanently protected from editing, as it is a heavily used or visible template.

Substantial changes should be proposed here, and made by administrators if the proposal is uncontroversial, or has been discussed and is supported by consensus. Use {{editprotected}} to attract the attention of an administrator in such cases.
Any contributor may edit the template's documentation to add usage notes, categories or interwiki links.

{{editprotected}}

Contents

[edit] Proposal

I propose the following code to automatically put a border around flags:

{{border|[[Image:{{
  #if: {{{variant|}}} | {{{flag alias-{{{variant}}}}}} | {{{flag alias}}}
}}|{{
  #if: {{{size|}}} | {{{size}}} | 22x20px
}}|Flag of {{{alias}}}]]|color=#aaa}} [[{{{alias}}}|{{
  #if: {{{name|}}} | {{{name}}} | {{{countryname|Earth}}} 
}}]]<noinclude>{{/doc}}</noinclude>

Alex(T|C|E) 02:19, 2 April 2007 (UTC)

I was hoping someone else would comment. Can you explain why this is a useful change? CMummert · talk 23:14, 3 April 2007 (UTC)
Oops, sorry, didn't check this page before. Some flags have borders around them just so that they look fine in this template. If the {{border}} template gets added, then this will be resolved. Except it could use a slightly darker border. — Alex(T|C|E) 20:37, 5 April 2007 (UTC)
I modified the code above. Take a look at the ukwiki version of the template that I created. That's how it would look like. — Alex(T|C|E) 20:44, 5 April 2007 (UTC)
Example of a page where the proposed template is used: uk:Центральний район. — Alex(T|C|E) 20:47, 5 April 2007 (UTC)
{{editprotected}}. There does not appear to be support for this proposal. CMummert · talk 16:51, 5 April 2007 (UTC)
I, for one do favor the revised version over the current one. --soum (0_o) 09:44, 6 April 2007 (UTC)
I made the change here, but now everything is inconsistent because not every flag template goes through this one. For example, see {{flagcountry}}. So you may want to request more edits to other templates. I don't plan to spend the time researching this myself to figure out exactly which other templates need to be changed, but if you do so I will make the changes (unless there are objections). CMummert · talk 19:17, 8 April 2007 (UTC)
Please revert this :-) The {{border}} template wraps the image in a div, and prevents inline images on the same line. For example, templates like {{USA}} are now forced into two lines (example: this should all be on Flag of the United States United States one line). This messes up many tables, and I'm sure quite a bit more. Carl Lindberg 20:31, 8 April 2007 (UTC)
I reverted it. I don't see the two-line effect on my browser, but apparently the border needs more testing. CMummert · talk 22:55, 8 April 2007 (UTC)
Thanks. I wasn't quite right on the div, but the template does use display:table-cell which is not consistent among browsers. In my case, I was using Safari. I don't think IE supports display:table-cell but maybe it happens to work out OK there. Carl Lindberg 00:29, 9 April 2007 (UTC)
I was using IE and everything worked fine. The template is working great on ukwiki for now. Hmm... — Alex(T|C|E) 00:39, 9 April 2007 (UTC)
Yep, I see the same problem on ukwiki (using this page to test). It does work OK in Firefox. According to this link Safari has a stricter interpretation (you can't really inline tables in regular HTML either) and IE has no support at all (but it happens to work I guess). Other browsers have other levels of support. This is the reason why many flags have bordered versions; they work without CSS trickery which has proven troublesome (unfortunately). Carl Lindberg 00:59, 9 April 2007 (UTC)

(De-indent) I'll download Konqueror and try to work on fixing this bug. — Alex(T|C|E) 02:59, 9 April 2007 (UTC)

...or not... — Alex(T|C|E) 03:01, 9 April 2007 (UTC)

Looks fine on Firefox 3.0 — Alex(T|C|E) 03:15, 9 April 2007 (UTC)

[edit] Extra noinclude

This template was broken by a recent edit. It has an extra <noinclude>. It should look like this:

<span style="white-space:nowrap"><!--

-->[[Image:{{#if:{{{variant|}}} |{{{flag alias-{{{variant}}}}}} |{{{flag alias}}} }}<!--
       -->|{{#if:{{{size|}}} |{{{size}}} |22x20px}}<!--
       -->|Flag of {{{alias}}}]] <!--
-->[[{{{alias}}}|{{#if:{{{name|}}} |{{{name}}} |{{{countryname|Earth}}} }}]]<!--

--></span><noinclude>
{{/doc}}

[[Category:Flag templates|µ]]
</noinclude>

The problem was reported at WP:VPT. Please fix as it is causing issues with Bronze Soldier of Tallinn and probably any article using {{flag}}. Mike Dillon 01:44, 5 May 2007 (UTC)

So THAT's what was causing it... It had me stomped. — Alex(U|C|E) 02:15, 5 May 2007 (UTC)
Hold on, let me test it. There might be something else wrong with it, too. — Alex(U|C|E) 02:16, 5 May 2007 (UTC)

Agreed with Mike's version. Please change ASAP. — Alex(U|C|E) 02:23, 5 May 2007 (UTC)

  • "Mea culpa!"  Many apologies for my oversight. Alex alerted me and I have now removed it; hope all is now fixed. Best wishes, David Kernow (talk) 02:32, 5 May 2007 (UTC)
    • Yep, now everything works the way it's supposed to. Thanks! — Alex(U|C|E) 02:33, 5 May 2007 (UTC)

Semi-related, my proposal for borders around flags:

<span style="white-space:nowrap"><!--

-->{{border|[[Image:{{#if:{{{variant|}}} |{{{flag alias-{{{variant}}}}}} |{{{flag alias}}} }}<!--
       -->|{{#if:{{{size|}}} |{{{size}}} |22x20px}}<!--
       -->|Flag of {{{alias}}}]]|color=#aaa}} <!--
-->[[{{{alias}}}|{{#if:{{{name|}}} |{{{name}}} |{{{countryname|Earth}}} }}]]<!--

--></span><noinclude>
{{/doc}}

[[Category:Flag templates|µ]]
</noinclude>

The &nbsp; seems to be unnecessary, I tested it on another wiki. — Alex(U|C|E) 02:49, 5 May 2007 (UTC)

[edit] It should be possible to have the wikilink vary by selected variant

I'll have code written in a little bit and put in an editprotected. --Random832 08:04, 6 May 2007 (UTC)

The idea was that you'd simply use a different Country_data_xxx template to get a different wikilink. For example, you'd use {{flag|Nazi Germany}} for World War II articles if you really want a wikilink to Nazi Germany, or {{flag|Germany|Nazi}} if you want that same flag, but still retain the link to Germany. This works because Template:Country data Germany and Template:Country data Nazi Germany are both available. I don't think it's a great idea to make these templates even more complex than they already are, when this mechanism works well enough. Andrwsc 17:15, 9 May 2007 (UTC)

[edit] Border edit by Andrewsc

{{editprotected}} I request that the edit by Andrewsc Andrwsc, adding grey borders around ALL flagicons, be undone. This change makes flagicons on literally thousands of pages ugly, and AFAIK has not been voted on anywhere. - PatrikR 20:41, 18 June 2007 (UTC)

Some discussion, albeit a small one, was held on this template's project page, Wikipedia talk:WikiProject Flag Template#Bordered flags. There was consensus for the change, as the previous alternative was irregular icon sizes and/or inconsistent border styles. Since the change, PatrikR has made the first and only objection to this change, but additional discussion is welcome. Andrwsc 20:45, 18 June 2007 (UTC)
PS: Template:country flagcountry2 and Template:country flagicon2 were edited in the same way so my request concerns those pages also. - PatrikR 20:55, 18 June 2007 (UTC)
Please figure out some consensus, preferably with the flags proect involved, and once that is reached we can edit the template if need be. Flip-flopping is the worst option. — Carl (CBM · talk) 03:22, 19 June 2007 (UTC)
Yeah, I'd prefer to keep this version up for a few days to see if there are any more comments. This is a very high-use template, so presumably more than four of us (three for, one against) have an opinion... Andrwsc 03:38, 19 June 2007 (UTC)
If you're counting me, I have no opinion, I only came to fill the editrequested tag. — Carl (CBM · talk) 04:09, 19 June 2007 (UTC)
No, I was counting Simmo676, Valentinian, and myself as the three pro-border people, and PatrikR as one against, all from the meagre discussion on the project talk page. Andrwsc 04:32, 19 June 2007 (UTC)